Skip to content

fix: don't able to call server when promotional code is empty #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2020
Merged

fix: don't able to call server when promotional code is empty #3818

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b61b4b3
fix: don't able to call server when promotional code is empty
maze-runnar Jan 18, 2020
5e0fcf1
Merge branch 'development' into patch-4
kushthedude Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/templates/components/public/ticket-list.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,10 @@
placeholder=(t 'Promotional Code')
readonly=promotionalCodeApplied
key-up=(action 'handleKeyPress')
id='promotionalCode'
}}
{{#unless promotionalCodeApplied}}
<div role="button" class="ui icon button" {{action 'applyPromotionalCode'}}>
<div role="button" class="ui icon {{if promotionalCode '' 'disabled'}} button" {{action 'applyPromotionalCode'}}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maze-runnar Is this really needed ? Validation should be taking care for empty input .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it was still calling the server and reloading the page.

<i class="checkmark icon"></i>
</div>
{{/unless}}
Expand Down