fix: don't able to call server when promotional code is empty #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kushthedude please review. |
snitin315
approved these changes
Jan 19, 2020
codedsun
approved these changes
Jan 19, 2020
uds5501
approved these changes
Jan 20, 2020
kushthedude
approved these changes
Jan 22, 2020
kushthedude
reviewed
Jan 22, 2020
| }} | ||
| {{#unless promotionalCodeApplied}} | ||
| <div role="button" class="ui icon button" {{action 'applyPromotionalCode'}}> | ||
| <div role="button" class="ui icon {{if promotionalCode '' 'disabled'}} button" {{action 'applyPromotionalCode'}}> |
There was a problem hiding this comment.
@maze-runnar Is this really needed ? Validation should be taking care for empty input .
There was a problem hiding this comment.
but it was still calling the server and reloading the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3815
Short description of what this resolves:
don't able to call server when promotional code is empty. So making the submit button disabled when promotional code is empty and also added validation to the field.
full flow of the promotional code field : https://youtu.be/34cZDbxJDDU
Checklist
developmentbranch.