fix: arrange unschedule session based on their event-time #3791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushthedude
reviewed
Jan 11, 2020
app/routes/my-sessions/list.js
Outdated
| let filterOptions = []; | ||
| if (params.session_status === 'upcoming') { | ||
| filterOptions = [ | ||
| filterOptions.push( |
There was a problem hiding this comment.
Dont refactor them. Just add the filter parameters
|
No its not wrong but keep one issue at a time, changing the array insertion
to push may also get shown in file blame which is not related to the PR.
…On Sat, 11 Jan, 2020, 18:40 Sundaram Dubey, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/routes/my-sessions/list.js
<#3791 (comment)>
:
> @@ -15,7 +15,7 @@ export default Route.extend(AuthenticatedRouteMixin, {
this.set('params', params);
let filterOptions = [];
if (params.session_status === 'upcoming') {
- filterOptions = [
+ filterOptions.push(
Is this wrong?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3791?email_source=notifications&email_token=AKQMTLWV5H2JTZRTRMMSQG3Q5HAMHA5CNFSM4KFQMLFKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRNTM2Q#discussion_r365520656>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLUNPZGJMAIYQVWFDV3Q5HAMHANCNFSM4KFQMLFA>
.
|
|
An after/before gif ? |
|
|
Looks good to me, squash the commits. |
arrange unschedule session based on their corresponding event
Done! please merge . |
kushthedude
changed the title
iamareebjamal
approved these changes
Jan 13, 2020
abhinavk96
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3702
Checklist
developmentbranch.