My Sessions: Shows past sessions in unscheduled session of past event in tab "Upcoming"

[mariobehling]

My Sessions: Shows past sessions in unscheduled session of past event in tab "Upcoming"
The private link is at https://eventyay.com/my-sessions/upcoming.
Furthermore the sessions shows up 4 x times.

EXPECTED: Even though the session is unscheduled, the system should take the time of the overall event. If the event is past the unscheduled session should also show up in the "past tab".

[kushthedude]

@mariobehling What about having a tab for Unscheduled, It would make more sense as showing sessions with time & date = null in upcoming and past doesn't seem nice ?

[maze-runnar]

@kushthedude while working on my-session showing multiple times issue , i solved this . Can i open a PR for it ,
Implementation is as @mariobehling has said.when session is unscheduled, the system should take the time of the overall event. If event is past , session is also past.

[kushthedude]

Sure

…

On Sat, 11 Jan, 2020, 00:44 Sundaram Dubey, ***@***.***> wrote: @kushthedude <https://github.com/kushthedude> while working on my-session showing multiple times issue , i solved this . Can i open a PR for it , Implementation is as @mariobehling <https://github.com/mariobehling> has said.when session is unscheduled, the system should take the time of the overall event. If event is past , session is also past. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3702?email_source=notifications&email_token=AKQMTLR4ZISBP626EIV5LGLQ5DCHXA5CNFSM4J3BFOQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIU5VLI#issuecomment-573168301>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLQUR5B3EZJ3YKMJYF3Q5DCHXANCNFSM4J3BFOQA> .

[kushthedude]

Remember dont use an conditional in template, query should not return those sessions .

…

On Sat, 11 Jan, 2020, 00:53 Kush Trivedi, ***@***.***> wrote: Sure On Sat, 11 Jan, 2020, 00:44 Sundaram Dubey, ***@***.***> wrote: > @kushthedude <https://github.com/kushthedude> while working on > my-session showing multiple times issue , i solved this . Can i open a PR > for it , > Implementation is as @mariobehling <https://github.com/mariobehling> has > said.when session is unscheduled, the system should take the time of the > overall event. If event is past , session is also past. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3702?email_source=notifications&email_token=AKQMTLR4ZISBP626EIV5LGLQ5DCHXA5CNFSM4J3BFOQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIU5VLI#issuecomment-573168301>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AKQMTLQUR5B3EZJ3YKMJYF3Q5DCHXANCNFSM4J3BFOQA> > . >

[maze-runnar]

ok, i will keep that in mind .

[maze-runnar]

actually making changes in open-event-frontend/app/routes/my-sessions/list.js .