Skip to content

Conversation

sharmaadityaHQ
Copy link
Member

Fixes #3623

Short description of what this resolves:

Fixed front end deployment link in README.md.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic PR Naming

@uds5501
Copy link
Contributor

uds5501 commented Nov 15, 2019

@sharmaaditya570191 basically rename it to fix: <current_pr_name> and change the commit message accordingly.

@sharmaadityaHQ sharmaadityaHQ changed the title Fixed front-end deployment link fix: front-end deployment link Nov 15, 2019
@auto-label auto-label bot added the fix label Nov 15, 2019

The **development** branch of open-event-frontend gets deployed at [https://opev-event-fe.netlify.com](https://opev-event-fe.netlify.com)
The **development** branch of open-event-frontend gets deployed at [https://open-event-fe.netlify.com](https://open-event-fe.netlify.com)
It consumes the API exposed by development branch of open event server, hosted at [https://open-event-api-dev.herokuapp.com](https://open-event-api-dev.herokuapp.com)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the server link too. Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server link is working fine.

@iamareebjamal iamareebjamal merged commit 128a12e into fossasia:development Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Development branch deployment link not working

7 participants