Skip to content

fix : Send test email box is showing properly in mobile also #3575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2019
Merged

fix : Send test email box is showing properly in mobile also #3575

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53a26da
fix : Send test email box is showing properly
maze-runnar Oct 25, 2019
23807a3
changing hide map button to toggle switch
maze-runnar Oct 26, 2019
54628d1
Undo previous commit
maze-runnar Oct 27, 2019
24c9b73
Merge branch 'development' into development
maze-runnar Oct 29, 2019
9c9d4e3
Merge branch 'development' into development
maze-runnar Oct 30, 2019
526a10e
Merge branch 'development' into development
abhinavk96 Nov 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions app/templates/components/forms/admin/settings/system/mail-settings/test-email-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
<i class="icon dropdown"></i>
{{t 'Send Test Email'}}
</div>
<div class="content four wide field">
Copy link
Member

@kushthedude kushthedude Oct 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make changes to this div only, there is no need to add an extra div.

Copy link
Contributor Author

@maze-runnar maze-runnar Oct 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without "ui grid" class how it is possible to make it responsible for both mobile and desktop @kushthedude
Is there any problem by adding an extra div ? 😶

Copy link
Member

@kushthedude kushthedude Oct 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use directly content 4 wide computer 6 wide mobile field

Copy link
Contributor Author

@maze-runnar maze-runnar Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried content 4 wide computer 16 wide mobile field but without ui grid how it is supposed to work . so i have to add extra div . and for mobile it should be 16 wide mobile field.

<div class="ui action input">
{{input type="text" placeholder=(t 'Recipient E-mail') name='test_email' value=recipientEmail }}
<div class="ui secondary button" role="button" {{action 'sendTestMail'}}>
{{t 'Test'}}
<div class = "content ui grid">
<div class="four wide computer four wide tablet sixteen wide mobile column ">
<div class="ui action input">
{{input type="text" placeholder=(t 'Recipient E-mail') name='test_email' value=recipientEmail }}
<div class="ui secondary button" role="button" {{action 'sendTestMail'}}>
{{t 'Test'}}
</div>
</div>
</div>
</div>
{{/ui-accordion}}
</div>
</div>