fix : Send test email box is showing properly in mobile also #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks @uds5501 |
thanks @snitin315 |
kushthedude
reviewed
Oct 27, 2019
| <i class="icon dropdown"></i> | ||
| {{t 'Send Test Email'}} | ||
| </div> | ||
| <div class="content four wide field"> |
There was a problem hiding this comment.
Make changes to this div only, there is no need to add an extra div.
There was a problem hiding this comment.
without "ui grid" class how it is possible to make it responsible for both mobile and desktop @kushthedude
Is there any problem by adding an extra div ? 😶
There was a problem hiding this comment.
Use directly content 4 wide computer 6 wide mobile field
There was a problem hiding this comment.
I have tried content 4 wide computer 16 wide mobile field but without ui grid how it is supposed to work . so i have to add extra div . and for mobile it should be 16 wide mobile field.
|
Cool then.
…On Mon, 28 Oct, 2019, 06:38 Sundaram Dubey, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
app/templates/components/forms/admin/settings/system/mail-settings/test-email-form.hbs
<#3575 (comment)>
:
> @@ -4,13 +4,15 @@
<i class="icon dropdown"></i>
{{t 'Send Test Email'}}
</div>
- <div class="content four wide field">
I have tried content 4 wide computer 16 wide mobile field but without ui
grid how it is supposed to work . so i have to add extra div . and for
mobile it should be 16 wide mobile field.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3575?email_source=notifications&email_token=AKQMTLTUFLDQDNBWDVJGCTLQQY3PNA5CNFSM4JFLPRU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJK4CTI#discussion_r339377222>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLQXAMF323GM24BCM53QQY3PNANCNFSM4JFLPRUQ>
.
|
|
So please approve this @kushthedude |
|
Squah your commits |
ghost
approved these changes
Oct 28, 2019
abhinavk96
approved these changes
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3574
previosly it was showing like this -
after fixing the issue it is -
for mobile device -
for pc -
Checklist
developmentbranch.