Skip to content

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 24, 2019

Fixes #3475

Short description of what this resolves:

Links modals to the server points asynchronously.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@Anupam-dagar Anupam-dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Still better to wait for other reviews.

@abhinavk96 abhinavk96 merged commit 80a8416 into fossasia:development Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link checkout modals to server endpoints

4 participants