test: add integration tests for paytm modals #3469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uds5501
force-pushed
the
test-modals
branch
2 times, most recently
from
bd0db75 to
c9a7a09
Compare
Anupam-dagar
suggested changes
Aug 23, 2019
|
@kushthedude @mrsaicharan1 Please review |
|
This needs to be updated once #3476 is updated |
Anupam-dagar
previously approved these changes
Aug 28, 2019
|
@Anupam-dagar I will update this PR today itself and ping you to review. |
uds5501
dismissed stale reviews from Anupam-dagar and shreyanshdwivedi
via
badfdb3
|
@shreyanshdwivedi @mrsaicharan1 @kushthedude @Anupam-dagar Please review |
abhinavk96
approved these changes
Aug 29, 2019
abhinavk96
suggested changes
Aug 29, 2019
tests/integration/components/modals/paytm-payment-options-test.js
Outdated
Show resolved
Hide resolved
shreyanshdwivedi
approved these changes
Aug 30, 2019
| 'isOpen' : false, | ||
| 'currency' : 'USD', | ||
| 'amount' : 100, | ||
| 'verifyOtp' : () => {} |
There was a problem hiding this comment.
This looks fine but what does this test exactly?
There was a problem hiding this comment.
In the current state, it checks rendering of the modal without actually hitting the API (gotta save the API calls xD )
abhinavk96
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3468
Short description of what this resolves:
Add integration tests for paytm modals\
Checklist
developmentbranch.