Skip to content

fix: phone number compulsory field remove #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 13, 2019
Merged

fix: phone number compulsory field remove #3378

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8245c83
user profile update:phone number compulsory field remove
Parth910 Aug 11, 2019
87e18fe
fix: phone field made optional
Parth910 Aug 11, 2019
7b32207
Update user-profile-form.hbs
Parth910 Aug 11, 2019
2a909af
Merge branch 'development' into development
Parth910 Aug 11, 2019
affcc58
Merge branch 'development' of https://github.com/fossasia/open-event-…
Parth910 Aug 11, 2019
51f5f97
add optional type and remove emtpy type
Parth910 Aug 12, 2019
9f0cb95
add optional type and remove emtpy type
Parth910 Aug 12, 2019
83a4133
Merge branch 'development' into development
abhinavk96 Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/components/forms/user-profile-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,16 @@ export default Component.extend(FormMixin, {
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Parth910 Just add

optional  : true,

Rest is done

Copy link
Member Author

@Parth910 Parth910 Aug 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for help, I made some unwanted changes. I have made requested changes.

phone: {
identifier : 'phone',
optional : true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need optional here?

rules : [
{
type : 'empty',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the empty rule completely, optional and empty both don't make sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

prompt : this.l10n.t('Please enter a phone number.')
prompt : this.l10n.t('Please enter a phone number')
},
{
type : 'regExp',
value : validPhoneNumber,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that after removing an "empty" type, a validator can't allow empty input in the phone field. so I just remove it and add inputtype=number.

prompt : this.l10n.t('Please enter a valid phone number.')
prompt : this.l10n.t('Please enter a valid phone number')
}
]
}
Expand Down