fix: phone number compulsory field remove #3378
Conversation
|
@kushthedude yes that's true, but here it was the compulsory field made by validation so no other way to make it optional. |
Are you sure ? |
| }, | ||
| { | ||
| type : 'regExp', | ||
| value : validPhoneNumber, |
There was a problem hiding this comment.
I think that after removing an "empty" type, a validator can't allow empty input in the phone field. so I just remove it and add inputtype=number.
| prompt : this.l10n.t('Please enter a valid email ID') | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for help, I made some unwanted changes. I have made requested changes.
kushthedude
changed the title
| optional : true, | ||
| rules : [ | ||
| { | ||
| type : 'empty', |
There was a problem hiding this comment.
remove the empty rule completely, optional and empty both don't make sense.
| }, | ||
| phone: { | ||
| identifier : 'phone', | ||
| optional : true, |
There was a problem hiding this comment.
Do we need optional here?
5 participants
Fixes #3289
Short description of what this resolves:
In the profile section, a phone number was a compulsory field, so I made it an optional field
Checklist
developmentbranch.