Skip to content

fix: Update GitHub URL Validator #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2019
Merged

fix: Update GitHub URL Validator #3326

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2030ad4
Update GitHub Validator
kushthedude Jul 30, 2019
c6bae26
Update GitHub Validator
kushthedude Jul 30, 2019
50295ff
Merge branch 'development' into url
kushthedude Jul 30, 2019
8361191
Merge branch 'development' into url
abhinavk96 Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/utils/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export const validFacebookProfileUrlPattern = new RegExp(

export const validGithubProfileUrlPattern = new RegExp(
'^(https?:\\/\\/)' // compulsory protocol
+ '?(?:www.)?github\\.com\\/([a-zA-Z0-9_]+)$'
+ '?(?:www.)?github\\.com\\/([a-zA-Z0-9_]+)([-]?)([a-zA-Z0-9_]+)$'
);

export const validLinkedinProfileUrlPattern = new RegExp(
Expand Down