fix: Update GitHub URL Validator #3326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushthedude
requested review from
abhinavk96,
mrsaicharan1,
shreyanshdwivedi and
uds5501
mrsaicharan1
previously approved these changes
Jul 30, 2019
uds5501
previously approved these changes
Jul 30, 2019
prateekj117
previously approved these changes
Jul 30, 2019
There was a problem hiding this comment.
LGTM.
@kushthedude can you please check for something like kush--the as continuos hyphens are unvalid according to GitHub standards
@shreyanshdwivedi Thanks for pointing fixed it Please check |
kushthedude
dismissed stale reviews from prateekj117, uds5501, and mrsaicharan1
via
c6bae26
|
@prateekj117 @uds5501 @mrsaicharan1 Please Review. |
Tried various username with the regex, it works with condition of none or one hyphen and an alphanumeric string |
|
@CosmicCoder96 Please Review |
uds5501
approved these changes
Jul 30, 2019
abhinavk96
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3324
Short description of what this resolves:
Screenshot :