Skip to content

fix: Showing Payment Options for Donations #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2019
Merged

fix: Showing Payment Options for Donations #3281

merged 2 commits into from
Jul 17, 2019

Conversation

@kushthedude
Copy link
Member

Fixes #3254

Short description of what this resolves:

  • Showing Payment Information in case for Donation Tickets too.

Screenshot

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 14, 2019
@kushthedude kushthedude mentioned this pull request Jul 14, 2019
Closed
5 tasks
@kushthedude kushthedude requested review from abhinavk96, niranjan94 and uds5501 and removed request for abhinavk96 and niranjan94 July 14, 2019 22:57
@kushthedude
Copy link
Member Author

@niranjan94 @CosmicCoder96 Please REview

mrsaicharan1
mrsaicharan1 reviewed Jul 15, 2019
View reviewed changes
@kushthedude kushthedude requested a review from mrsaicharan1 July 15, 2019 05:10
prateekj117
prateekj117 approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@prateekj117 prateekj117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushthedude kushthedude merged commit a851222 into fossasia:development Jul 17, 2019
@kushthedude kushthedude deleted the 3255 branch July 17, 2019 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niranjan94 niranjan94 Awaiting requested review from niranjan94

@abhinavk96 abhinavk96 Awaiting requested review from abhinavk96

4 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@prateekj117 prateekj117 prateekj117 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Event Wizard: Show Payment Options when only Donation Tickets are there.

5 participants

@kushthedude @uds5501 @mrsaicharan1 @shreyanshdwivedi @prateekj117