fix: Showing Payment Options for Donations
#3255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anupam-dagar
previously approved these changes
Jul 10, 2019
uds5501
suggested changes
Jul 10, 2019
kushthedude
dismissed stale reviews from prateekj117, mrsaicharan1, and Anupam-dagar
via
636e74a
kushthedude
changed the title
Payment Options for DonationsPayment Options for Donations
mrsaicharan1
suggested changes
Jul 11, 2019
kushthedude
changed the title
Payment Options for DonationsPayment Options for Donations
|
@mrsaicharan1 @niranjan94 Please take a look here, @computed decorator didn't do any good, So tried different way according to their docs. |
|
@kushthedude I think we could follow ES6 styled computed properties for new resources. |
niranjan94
suggested changes
Jul 11, 2019
abhinavk96
approved these changes
Jul 12, 2019
abhinavk96
suggested changes
Jul 12, 2019
|
@CosmicCoder96 Please Check now |
abhinavk96
suggested changes
Jul 12, 2019
abhinavk96
suggested changes
Jul 12, 2019
|
@CosmicCoder96 Did the requested change |
niranjan94
suggested changes
Jul 13, 2019
|
@niranjan94 @CosmicCoder96 Please Review |
kushthedude
requested review from
abhinavk96,
mrsaicharan1,
niranjan94,
shreyanshdwivedi and
uds5501
and removed request for
abhinavk96,
mrsaicharan1,
niranjan94,
shreyanshdwivedi and
uds5501
niranjan94
suggested changes
Jul 14, 2019
| hasPaidTickets: computed('data.event.tickets.[]', function() { | ||
| return filter(this.get('data.event.tickets').toArray(), ticket => ticket.get('type') === 'paid').length > 0; | ||
| hasPaidTickets: computed('data.event.tickets.@each.type', function() { | ||
| return filter(this.data.event.tickets.toArray(), ticket => ticket.type === 'paid' || ticket.type === 'donation').length > 0; |
There was a problem hiding this comment.
Use native filter function.
this.data.event.tickets.toArray().filter(
Closed in favour of #3281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3254
Short description of what this resolves:
Payment Informationin case forDonation Ticketstoo.Screenshot
Checklist
developmentbranch.