Skip to content

fix: Fixing Overlapping Components in Manage Events #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 6, 2019
Merged

fix: Fixing Overlapping Components in Manage Events #3241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
43cd360
Fixing Overlapping Components
kushthedude Jul 4, 2019
c3370a2
Fixing Overlapping Components
kushthedude Jul 5, 2019
df60720
Merge branch 'development' into sample
kushthedude Jul 5, 2019
2e1edd5
Merge branch 'development' into sample
kushthedude Jul 6, 2019
92243bd
Merge branch 'development' into sample
abhinavk96 Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/controllers/events/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
{
name : 'Name',
valuePath : 'name',
width : 150,
isSortable : true,
extraValuePaths : ['startsAt', 'endAt'],
headerComponent : 'tables/headers/sort',
Expand All @@ -34,6 +35,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
{
name : 'Roles',
valuePath : 'roles',
width : 180,
cellComponent : 'ui-table/cell/cell-roles',
isSortable : false
},
Expand All @@ -60,6 +62,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
{
name : 'Public URL',
valuePath : 'url',
width : 250,
cellComponent : 'ui-table/cell/cell-link',
isSortable : false
}
Expand Down
19 changes: 9 additions & 10 deletions app/extensions/ember-table/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
<div class="resize-container">
<table class="ui unstackable table">
{{yield (hash
api=api
head=(component "ember-thead" api=api)
body=(component "ember-tbody" api=api)
foot=(component "ember-tfoot" api=api)
)}}
</table>
</div>

<table class="ui unstackable table">
{{yield (hash
api=api
head=(component "ember-thead" api=api)
body=(component "ember-tbody" api=api)
foot=(component "ember-tfoot" api=api)
)}}
</table>