Skip to content

fix: Fixing Overlapping Components in Manage Events #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 6, 2019
Merged

fix: Fixing Overlapping Components in Manage Events #3241

merged 5 commits into from
Jul 6, 2019

Conversation

kushthedude
Copy link
Member

Fixes #3240

Short description of what this resolves:

  • A workaround for fixing Overlapping Components in Ember Table

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 4, 2019
abhinavk96
abhinavk96 suggested changes Jul 4, 2019
View reviewed changes
@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 Just tried to tweak with column widths and its best combination I found which prevents collapsing in smallest mobile view too. Till we don't have any good solution, I think it can be merged.

@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 Please check.

@abhinavk96 abhinavk96 merged commit 55e8e68 into fossasia:development Jul 6, 2019
@kushthedude kushthedude deleted the sample branch July 6, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niranjan94 niranjan94 Awaiting requested review from niranjan94

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

@uds5501 uds5501 Awaiting requested review from uds5501

1 more reviewer

@abhinavk96 abhinavk96 abhinavk96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ember Table: Overlapping Components of Ember Table in Manage Events

2 participants

@kushthedude @abhinavk96