Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tracy for error handling #1298

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Use Tracy for error handling #1298

wants to merge 3 commits into from

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 25, 2021

Tracy produces much nicer error messages and allows us to get rid of F3.

The version supporting PHP 5.6 unfortunately produces warnings on PHP 8.0. Also until Tracy 2.9 (for PHP 7.3+) starts a session, which conflicts with session_set_cookie_params.

  • we need to convince tracy to log even in dev mode – likely by subclassing
  • Find out why ajax requests do not appear in tracy panel seems to work with 2.9
  • integrate PDO into tracy panel

If Tracy does not see Content-Type or sees text/html,
it will inject its JavaScript, which breaks tests
that compare response body.
Since the switch to Tracy, timezone warnings started to occur.
These are no an issue on PHP 7+:
php/doc-en#1238

Also fix path to php.ini.
It offers much nicer error traces and the code is significantly cleaner.

This was the last thing we used F3 framework for.
Now we are officially fat-free-free.

So long and thanks for all the fish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant