date_default_timezone_get: unmention the warning #1238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has not been the case since PHP 7.0: php/php-src@b22caa8
jtojnar
added a commit
to fossar/selfoss
that referenced
this pull request
Dec 22, 2021
Since the switch to Tracy, timezone warnings started to occur. These are no an issue on PHP 7+: php/doc-en#1238 Also fix path to php.ini.
Girgias
reviewed
Dec 24, 2021
Comment on lines
+37
to
+40
| <para> | ||
| To make sure the return value matches reality, explicitly set <link linkend="ini.date.timezone">date.timezone</link> | ||
| to the correct timezone instead of relying on the guessing. | ||
| </para> |
There was a problem hiding this comment.
I think this can just be dropped altogether, as no guessing is performed anymore
There was a problem hiding this comment.
I think it is still valuable to emphasize that the value is useless unless set explicitly. Maybe something like “Note that date.timezone does not default to the timezone of the operating system so you need to set the option explicitly to have it match reality.”
There was a problem hiding this comment.
Yeah, but why document that for date_default_timezone_get()?
jtojnar
added a commit
to fossar/selfoss
that referenced
this pull request
Dec 25, 2021
Since the switch to Tracy, timezone warnings started to occur. These are no an issue on PHP 7+: php/doc-en#1238 Also fix path to php.ini.
jtojnar
added a commit
to fossar/selfoss
that referenced
this pull request
Dec 25, 2021
Since the switch to Tracy, timezone warnings started to occur. These are no an issue on PHP 7+: php/doc-en#1238 Also fix path to php.ini.
tiffany-taylor
pushed a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Jan 16, 2023
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has not been the case since PHP 7.0:
php/php-src@b22caa8