Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove low priority validation #2891

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Conversation

jaredpalmer
Copy link
Owner

@jaredpalmer jaredpalmer commented Nov 11, 2020

This PR removes all low-priority validation entirely.

After speaking with React core team this morning, the way we are using scheduler isn't as intended and will likely cause bugs like the ones we've been seeing since 2.2.x based on different use cases.

Related to #2892

@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/formik/8pv6p572c
✅ Preview: https://formik-git-remove-low-pri-validation.formium.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2020

🦋 Changeset detected

Latest commit: ebad985

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
formik Patch
formik-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2020

Size Change: -1.61 kB (4%)

Total Size: 39.7 kB

Filename Size Change
packages/formik/dist/formik.cjs.development.js 15.9 kB -733 B (4%)
packages/formik/dist/formik.cjs.production.min.js 6.96 kB -127 B (1%)
packages/formik/dist/formik.esm.js 15.8 kB -752 B (4%)
ℹ️ View Unchanged
Filename Size Change
packages/formik-native/dist/formik-native.cjs.development.js 306 B 0 B
packages/formik-native/dist/formik-native.cjs.production.min.js 242 B 0 B
packages/formik-native/dist/formik-native.esm.js 238 B 0 B
packages/formik-native/dist/index.js 150 B 0 B
packages/formik/dist/index.js 143 B 0 B

compressed-size-action

@jaredpalmer jaredpalmer mentioned this pull request Nov 11, 2020
@jaredpalmer jaredpalmer marked this pull request as ready for review November 11, 2020 18:13
@jaredpalmer jaredpalmer merged commit 1a9688c into master Nov 11, 2020
@jaredpalmer jaredpalmer deleted the remove-low-pri-validation branch November 11, 2020 18:14
@github-actions github-actions bot mentioned this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant