Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device registry for casts and spotify devices #178

Merged
merged 9 commits into from
Apr 11, 2021

Conversation

fondberg
Copy link
Owner

This PR replaces #176. #177 got added as well but it should not break anything (tired and forgot to rebase)

Copy link

@KapJI KapJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

custom_components/spotcast/sensor.py Outdated Show resolved Hide resolved
custom_components/spotcast/__init__.py Show resolved Hide resolved
@fondberg fondberg merged commit ab6de38 into master Apr 11, 2021
@fondberg fondberg deleted the use_device_registry_for_casts_and_spotify_devices branch April 11, 2021 16:55
@fondberg fondberg mentioned this pull request Apr 11, 2021
@hmmbob
Copy link
Contributor

hmmbob commented Apr 11, 2021

@fondberg It works for me, yet it does throw errors in the log. But - it works in my use case. Started it twice to verify if this was a single occurrence - happened both times.

Error:

2021-04-11 19:22:02 ERROR (SyncWorker_14) [custom_components.spotcast] No device with id "bf7485e4bdc069dfdaaa748826af2f02" known by Spotify
2021-04-11 19:22:02 ERROR (SyncWorker_14) [custom_components.spotcast] Known devices: []
2021-04-11 19:23:20 ERROR (SyncWorker_11) [custom_components.spotcast] No device with id "bf7485e4bdc069dfdaaa748826af2f02" known by Spotify
2021-04-11 19:23:20 ERROR (SyncWorker_11) [custom_components.spotcast] Known devices: []

Used HA script:

#############################
## Start sleeping music     #
#############################
start_music_t:
  alias: Slaaptijd
  mode: restart
  sequence:
    - service: spotcast.start
      data:
        account: "t"
        entity_id: media_player.hmt
        uri: "spotify:track:5OoSxxxxbP1p7kb1d0SozG"

(device id and track redacted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants