Episodes shows #177
Closed
Episodes shows #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KapJI
approved these changes
Apr 11, 2021
| @@ -14,7 +14,7 @@ | |||
| from homeassistant.components.cast.helpers import ChromeCastZeroconf | |||
| from homeassistant.components.spotify.media_player import KNOWN_SPOTIFY_DEVICES | |||
|
|
|||
| __VERSION__ = "3.5.0" | |||
| __VERSION__ = "3.5.1" | |||
There was a problem hiding this comment.
Do you really need this? Component verison should be in manifest.json.
| if uri.find("track") > 0: | ||
| if uri.find("show") > 0: | ||
| show_episodes_info = client.show_episodes(uri) | ||
| if show_episodes_info and len(show_episodes_info["items"]) > 0: |
There was a problem hiding this comment.
Suggested change
| if show_episodes_info and len(show_episodes_info["items"]) > 0: | |
| if show_episodes_info and show_episodes_info["items"]: |
There was a problem hiding this comment.
Saw your review now! Thanks, I'm nackered now after a whole day fixing. Can you open a new PR?
|
accidently released with #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.