clang-format 19#1378
Merged
Merged
Conversation
DoozyX/clang-format-lint-action is still at version 18. This commit is trying to fetch from the forked repo d-griet/clang-format-lint-action.
We decided to insert a space after control statements and after a requires clause.
fnc12
approved these changes
Jan 25, 2025
| } | ||
| }; | ||
| #endif | ||
| SECTION("acos"){SECTION("simple"){auto rows = storage.select(sqlite_orm::acos(1)); |
Collaborator
Author
There was a problem hiding this comment.
You mean it WAS, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang tooling goes at a fast pace...
clang-format 18 is buggy (e.g.), and 19 apparently changed some defaults as one can infer from the changeset of this PR.
Note: the code linting github action DoozyX/clang-format-lint-action is still at clang-format 18. So temporarily we use fork d-griet/clang-format-lint-action for which @d-griet made a PR.