Add clang-format 19#82
Merged
Merged
Conversation
Signed-off-by: Darrel Griët <d.griet@dynatron.nl>
|
@DoozyX @d-griet Great work! Are there any plans to also add clang-format version 19.1? Preferably 19.1.4, as that's the version required by ITK (pull request InsightSoftwareConsortium/ITK#5015). |
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Feb 11, 2025
Dropped https://github.com/DoozyX/clang-format-lint-action in order to upgrade to clang-format 19.1.4, following ITK pull request InsightSoftwareConsortium/ITK#5015 Reverts commit 8ac0413, "STYLE: add clang format check", by Viktor van der Valk, 11 Dec 2020. Note: there is a pull request to add clang-format 19 to DoozyX/clang-format-lint-action, by Darrel Griët: DoozyX/clang-format-lint-action#82
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Feb 11, 2025
Dropped https://github.com/DoozyX/clang-format-lint-action in order to upgrade to clang-format 19.1.4, following ITK pull request InsightSoftwareConsortium/ITK#5015 Reverts commit 8ac0413, "STYLE: add clang format check", by Viktor van der Valk, 11 Dec 2020. Note: there is a pull request to add clang-format 19 to DoozyX/clang-format-lint-action, by Darrel Griët: DoozyX/clang-format-lint-action#82
|
@DoozyX do you need something else to merge this? |
|
Is there a plan to keep this repository up to date or should users move to https://github.com/jidicula/clang-format-action? |
|
Well, this action is orders of magnitudes faster than the one referenced for our repo (less than 30 seconds versus many minutes), due to parallelisation and launch method. |
|
@echoix, nice! That's great to know. I really like this action, I'm just wondering if there is any plan to update it. |
|
Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for clang-format 19.