Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2022 17.2: C4189: 'zero': local variable is initialized but not referenced #2891 #2892

Merged
merged 2 commits into from
May 13, 2022
Merged

VS2022 17.2: C4189: 'zero': local variable is initialized but not referenced #2891 #2892

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf554b
VS2022 17.2: C4189: 'zero': local variable is initialized but not ref…
May 12, 2022
858bcc1
VS2022 17.2: C4189: 'zero': local variable is initialized but not ref…
May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2203,7 +2203,7 @@ FMT_CONSTEXPR20 auto do_write_float(OutputIt out, const DecimalFP& fp,
-> OutputIt {
auto significand = fp.significand;
int significand_size = get_significand_size(fp);
constexpr Char zero = static_cast<Char>('0');
Char zero = static_cast<Char>('0');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it const so that it doesn't add to lambda capture.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked - compiles without warnings!

auto sign = fspecs.sign;
size_t size = to_unsigned(significand_size) + (sign ? 1 : 0);
using iterator = reserve_iterator<OutputIt>;
Expand Down