VS2022 17.2: C4189: 'zero': local variable is initialized but not referenced #2891 #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The warning looks wrong because Line 2244 in f6f920a |
|
Reported to Microsoft with a sample to reproduce - https://godbolt.org/z/cT6sKs3dY https://developercommunity.visualstudio.com/t/CL-version-193231328-generates-false-w/10040986 |
vitaut
reviewed
May 13, 2022
include/fmt/format.h
Outdated
| @@ -2203,7 +2203,7 @@ FMT_CONSTEXPR20 auto do_write_float(OutputIt out, const DecimalFP& fp, | |||
| -> OutputIt { | |||
| auto significand = fp.significand; | |||
| int significand_size = get_significand_size(fp); | |||
| constexpr Char zero = static_cast<Char>('0'); | |||
| Char zero = static_cast<Char>('0'); | |||
There was a problem hiding this comment.
Let's make it const so that it doesn't add to lambda capture.
There was a problem hiding this comment.
Just checked - compiles without warnings!
|
Updated PR with |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.