Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting with compile-time API when format string is empty #2042

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fix formatting with compile-time API when format string is empty #2042

merged 1 commit into from
Dec 2, 2020

Conversation

alexezeder
Copy link
Contributor

Right now {fmt} cannot be used with empty string format with compile-time API, while it can be used with regular API:

fmt::format(""); // ok
fmt::format(FMT_COMPILE("")); // compilation error

Proof on Compiler Explorer

With this tiny fix, compile-time API also get this useless feature.
Also, a test for FMT_COMPILE with an empty string added.

@vitaut vitaut merged commit 683a745 into fmtlib:master Dec 2, 2020
@vitaut
Copy link
Contributor

vitaut commented Dec 2, 2020

Thank you!

@yeswalrus yeswalrus mentioned this pull request Dec 2, 2020
Closed
vitaut pushed a commit that referenced this pull request Dec 3, 2020
@alexezeder @vitaut
fix formatting with empty compiled format string (#2042)
713bf76
vitaut pushed a commit that referenced this pull request Dec 3, 2020
@alexezeder @vitaut
fix formatting with empty compiled format string (#2042)
c609ebf
@vitaut vitaut mentioned this pull request Dec 3, 2020
Closed
@alexezeder alexezeder deleted the fix/empty_compile_format_string branch January 15, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexezeder @vitaut