Document FMT_STRING requires >C++14 #2041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Dec 2, 2020
Comment on lines
+164
to
+165
| ``FMT_STRING`` may function in C++11 environments, but is not supported and can | ||
| produce illegible error messages. It is also known to fail in GCC when passing zero arguments. |
There was a problem hiding this comment.
This is no longer the case, please remove.
There was a problem hiding this comment.
#2042 only fixed this for FMT_COMPILE, not FMT_STRING in old gcc versions?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the title & conversation in #2039, updates the documentation.