#184 avoid loading CJK fonts by default#204
Merged
Merged
Conversation
1. extracted CJK-specific part from ITextFontResolver to a subclass CJKFontResolver 2. Users can pass it to ITextRenderer, e.g. `new ITextRenderer(new CJKFontResolver())`
Merged
asolntsev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new ITextRenderer(new CJKFontResolver())P.S. In fact, there is no more need to exclude CJK fonts after PR LibrePDF/OpenPDF#955 gets merged in OpenPDF. This PR will fix loading speed of CJK fonts.
But anyway, I decided to make CJK fonts optional because they also consume some amount of memory (and probably not needed for most customers).