Make CJKFont optional#184
Merged
Merged
Conversation
ITextFontResolver init is very slow on my computer and server (8000ms). After some research, it seems that createInitialFontMap() method take too much time. The cause is the cjkfonts which I did not use. Is it possible to make this loading optional ? Thanks a lot
asolntsev
approved these changes
Aug 7, 2023
Member
|
@sc-mickael Upvote for this change. Loading Asian fonts takes ~5 seconds - which is too slow when we run unit-tests or re-generate PDF while developing templates. The initial intention was to load these fonts ONLY if file But nowadays file |
Member
|
Released 9.2.0 |
Contributor
Author
|
Thanks a lot ! I tried it and it seems to work! |
asolntsev
added a commit
that referenced
this pull request
Sep 25, 2023
1. extracted CJK-specific part from ITextFontResolver to a subclass CJKFontResolver 2. Users can pass it to ITextRenderer, e.g. `new ITextRenderer(new CJKFontResolver())`
Member
|
For the record: later I converted parameter |
asolntsev
added a commit
that referenced
this pull request
Sep 25, 2023
1. extracted CJK-specific part from ITextFontResolver to a subclass CJKFontResolver 2. Users can pass it to ITextRenderer, e.g. `new ITextRenderer(new CJKFontResolver())`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITextFontResolver init is very slow on my computer and server (8000ms). After some research, it seems that createInitialFontMap() method take too much time. The cause is the cjkfonts which I did not use.
Is it possible to make this loading optional ?
Thanks a lot