[Draft] Pin to clang18 #185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to common.hpp/cpp as opposed to just the current hpp file.
does not include PassManagerBuilder.h header that was removed in clang17
getInt8PtrTy removed in clang18
…Aspect into updating_to_clang15
|
|
|
|
|
Will update #182 with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at file changes relative to
mainbranch@tpatki @loudsun1997 At a first glance, this might not be so bad updating the PR base branch to main. I don't see the deleted legacy.hpp files we saw in #182. I think still needs some cleanup to remove remaining legacy references, but might not have any many conflicts to resolve as we were initially thinking?