-
Couldn't load subscription status.
- Fork 17
Update minimum Clang version requirement to Clang 18 #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slabasan
merged 76 commits into
flux-framework:main
from
loudsun1997:updating_to_clang15
Apr 4, 2025
Merged
Update minimum Clang version requirement to Clang 18 #182
slabasan
merged 76 commits into
flux-framework:main
from
loudsun1997:updating_to_clang15
Apr 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
…to common.hpp/cpp as opposed to just the current hpp file.
does not include PassManagerBuilder.h header that was removed in clang17
getInt8PtrTy removed in clang18
bac49b2 to
5bca920
Compare
ee1d145 to
e391fcf
Compare
|
Things we need to fix:
|
clang, llvm pinned to 18.0 flex pinned to 2.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175.
Summary
• Updated minimum Clang version to Clang 18.
• Clang18 builds successfully but requires CUDA 12.8 on NVIDIA systems. CUDA 12.4 is not supported with Clang 18.
Notes
• Tested on WPI Turing, Tuo and Tioga systems.
• Users must upgrade to CUDA 12.8 or later for NVIDIA systems.
This pull request includes several changes to update the project to require Clang 18.0.
The most important changes include updating the CMake configuration, removing conditional compilation based on older Clang versions, and cleaning up the codebase.