Skip to content

Conversation

@loudsun1997
Copy link
Collaborator

@loudsun1997 loudsun1997 commented Feb 19, 2025

Fixes #175.

Summary
• Updated minimum Clang version to Clang 18.
• Clang18 builds successfully but requires CUDA 12.8 on NVIDIA systems. CUDA 12.4 is not supported with Clang 18.

Notes
• Tested on WPI Turing, Tuo and Tioga systems.
• Users must upgrade to CUDA 12.8 or later for NVIDIA systems.

This pull request includes several changes to update the project to require Clang 18.0.
The most important changes include updating the CMake configuration, removing conditional compilation based on older Clang versions, and cleaning up the codebase.

@tpatki tpatki requested review from slabasan and tpatki March 4, 2025 20:49
@tpatki
Copy link
Member

tpatki commented Mar 4, 2025

  • @loudsun1997 : Please run the check-c-code-format.sh in the scripts directory to format the code.
  • @tpatki and @slabasan need to update GitHub CI checks to Clang18 only.
  • @tpatki Need to test on Tioga/Tuo.

@mergify mergify bot mentioned this pull request Apr 3, 2025
@slabasan slabasan changed the base branch from update_newpassmgr to main April 3, 2025 20:56
@slabasan slabasan force-pushed the updating_to_clang15 branch from bac49b2 to 5bca920 Compare April 3, 2025 21:40
@slabasan slabasan force-pushed the updating_to_clang15 branch from ee1d145 to e391fcf Compare April 3, 2025 22:00
@tpatki
Copy link
Member

tpatki commented Apr 4, 2025

Things we need to fix:

  • Remove the hostconfigs that are clang 10-17
  • Create a new hostfile for Tioga for amdclang-18
  • Create a new hostfile for Tuo for amdclang-18
  • Clean up comments with older clang versions (weave_common, weaver-CMakefile), check other places for things that are commented and mention Clang9-17.
  • Clean up LLVM pass messages other than NewWeavePass loaded successfully! (appear when building smoketests)
  • Remove PERFFLOWASPECT_CLANG_18_NEWER from build

@slabasan slabasan merged commit 42e81a5 into flux-framework:main Apr 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin PFA main branch to clang-18

3 participants