-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #331 cookies parsing #351
base: master
Are you sure you want to change the base?
Conversation
use standard Activity as calling class to support FlutterFragmentActivity
add eval javascript sink onUrlChanged ...
fix document
android: add rect, fullScreen, userAgent, eval
ios and android more implement
ready to 0.0.10
iOS delegate and some features
[Android] Back button navigates back now instead of closing webview
Add pub badge
Add pub badge to README
Fix Hide/Show WebView
hotfix widget back to initialChild after webview is tapped on Android
remove first and last extra quotes
I think this will still cause the spaces in the cookie names. |
Well, I can't think of how. The tokens used for splitting are special characters like |
@cTatu Thank you for PR. I'd like to merge this one, but due to my time limitation, could you please provide easy to test / steps to reproduce, so I can check if it's working? Thanks |
@charafau Sure, I will check with all sorts of values and upload a test file. Think that will be enough? |
@cTatu anything will do really :) |
Ok here you have the test comparing the old and new methods ;) Also fixes #418 taking the first |
I assume this also fixes #525 since you removed the hardcoded access at index 1? edit: Or maybe not. If |
Yes, also fixes #525, the case where the
I have updated the dartpad test with an empty string case if you want to check it out! |
Good to hear, thanks. But I can't get your DartPad test to run. I always get
|
That's weird, it even works on my phone's browser 😕 |
The "positive lookbehind" feature may not be supported in all browsers.
|
Ah, yes, that's it. https://caniuse.com/#feat=js-regexp-lookbehind |
when does it be released? |
remove first and last extra quotes as suggested in #331