Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The getCookies method may need to be improved #418

Open
w4mxl opened this issue May 15, 2019 · 1 comment
Open

The getCookies method may need to be improved #418

w4mxl opened this issue May 15, 2019 · 1 comment

Comments

@w4mxl
Copy link

w4mxl commented May 15, 2019

When I found a minor problem with the getCookies method, I looked at the source code, on line 224 of base.dart,

final split = cookie.split('=');

If there is also '=' in the cookie value, the result of the split is not correct.

@charafau
Copy link
Collaborator

thanks for reporting this. I think this might be related - #351
but I need someone to check if that fixes your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants