Skip to content

Update clear button example#3045

Closed
aloksingh3112 wants to merge 1 commit into
flutter:masterfrom
aloksingh3112:patch-1
Closed

Update clear button example#3045
aloksingh3112 wants to merge 1 commit into
flutter:masterfrom
aloksingh3112:patch-1

Conversation

@aloksingh3112

Copy link
Copy Markdown

update clear button with wrong example on 'Simple app state management' #2906

update clear button with wrong example on 'Simple app state management' flutter#2906
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Sep 30, 2019
@legalcodes legalcodes requested a review from filiph October 9, 2019 20:50
@legalcodes legalcodes added p2-medium Necessary but not urgent concern. Resolve when possible. e0-minutes Effort: < 60 min labels Oct 9, 2019
@filiph

filiph commented Oct 10, 2019

Copy link
Copy Markdown
Contributor

Hi @aloksingh3112, well spotted! Thanks for the contribution!

This sample excerpt is tested. You'll find the source over in https://github.com/flutter/website/blob/master/examples/state_mgmt/simple/lib/src/performance.dart#L101. Could you please update also that line (in a way that still passes tests)? That probably means adding removeAll() to CartModel, or calling something else (.items.clear()?).

More info about how sample excerpts are tested can be found over at https://github.com/dart-lang/site-shared/blob/master/doc/examples.md.

@legalcodes

Copy link
Copy Markdown
Contributor

Hi @aloksingh3112 just want to bump this request for changes -- any chance you can update the source code that @filiph mentioned?

@legalcodes legalcodes self-requested a review October 22, 2019 15:06

@legalcodes legalcodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See request for changes in comment from filiph:

This sample excerpt is tested. You'll find the source over in https://github.com/flutter/website/blob/master/examples/state_mgmt/simple/lib/src/performance.dart#L101. Could you please update also that line (in a way that still passes tests)? That probably means adding removeAll() to CartModel, or calling something else (.items.clear()?).

More info about how sample excerpts are tested can be found over at https://github.com/dart-lang/site-shared/blob/master/doc/examples.md.

@legalcodes

legalcodes commented Dec 19, 2019

Copy link
Copy Markdown
Contributor

I am working to resolve this PR, and its attending PR #3140

I've raised an issue (#3463) that I ran into while doing so.

@sfshaza2

Copy link
Copy Markdown
Contributor

Coalesced two PRs into one and did some other editing, as well. This PR is subsumed by #3568

Closing.

@sfshaza2 sfshaza2 closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement e0-minutes Effort: < 60 min p2-medium Necessary but not urgent concern. Resolve when possible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants