Update clear button example#3045
Conversation
update clear button with wrong example on 'Simple app state management' flutter#2906
|
Hi @aloksingh3112, well spotted! Thanks for the contribution! This sample excerpt is tested. You'll find the source over in https://github.com/flutter/website/blob/master/examples/state_mgmt/simple/lib/src/performance.dart#L101. Could you please update also that line (in a way that still passes tests)? That probably means adding More info about how sample excerpts are tested can be found over at https://github.com/dart-lang/site-shared/blob/master/doc/examples.md. |
|
Hi @aloksingh3112 just want to bump this request for changes -- any chance you can update the source code that @filiph mentioned? |
legalcodes
left a comment
There was a problem hiding this comment.
See request for changes in comment from filiph:
This sample excerpt is tested. You'll find the source over in https://github.com/flutter/website/blob/master/examples/state_mgmt/simple/lib/src/performance.dart#L101. Could you please update also that line (in a way that still passes tests)? That probably means adding removeAll() to CartModel, or calling something else (.items.clear()?).
More info about how sample excerpts are tested can be found over at https://github.com/dart-lang/site-shared/blob/master/doc/examples.md.
|
Coalesced two PRs into one and did some other editing, as well. This PR is subsumed by #3568 Closing. |
update clear button with wrong example on 'Simple app state management' #2906