Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Revert the wait-on-check hash change #4287

Merged
merged 7 commits into from
Aug 27, 2021
Merged

[ci] Revert the wait-on-check hash change #4287

merged 7 commits into from
Aug 27, 2021

Conversation

cyanglaz
Copy link
Contributor

Revert the changes in #4286 and #4262 for now until the new hash is whitelisted.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from stuartmorgan August 27, 2021 19:08
@google-cla google-cla bot added the cla: yes label Aug 27, 2021
stuartmorgan
stuartmorgan approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit 4f4a889 into flutter:master Aug 27, 2021
@cyanglaz cyanglaz deleted the reduce_wait_output branch August 27, 2021 19:18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2021
@engine-flutter-autoroll
4f4a889 [ci] Revert the wait-on-check hash change (flutter/plugins#4287)
7079347
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2021
@engine-flutter-autoroll
4f4a889 [ci] Revert the wait-on-check hash change (flutter/plugins#4287)
5b48e0d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2021
@engine-flutter-autoroll
4f4a889 [ci] Revert the wait-on-check hash change (flutter/plugins#4287)
c6b337e
cyanglaz pushed a commit that referenced this pull request Aug 28, 2021
Revert "[ci] Revert the wait-on-check hash change (#4287)"
0b1e245 
This reverts commit 4f4a889.
stuartmorgan pushed a commit that referenced this pull request Aug 28, 2021
Revert "[ci] Revert the wait-on-check hash change (#4287)" (#4289)
32ca776 
Relands #4262 as the white list has been updated to allow the newer wait-on-check version.
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@fotiDim
[ci] Revert the wait-on-check hash change (flutter#4287)
a33677c
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@fotiDim
Revert "[ci] Revert the wait-on-check hash change (flutter#4287)" (fl…
33bc083 
…utter#4289)

Relands flutter#4262 as the white list has been updated to allow the newer wait-on-check version.
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@amantoux
[ci] Revert the wait-on-check hash change (flutter#4287)
05f7c47
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@amantoux
Revert "[ci] Revert the wait-on-check hash change (flutter#4287)" (fl…
997d6bf 
…utter#4289)

Relands flutter#4262 as the white list has been updated to allow the newer wait-on-check version.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyanglaz @stuartmorgan