This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[ci] update wait-on-check version and set verbose to false #4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for following up on it!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2021
Yeeessss, amazing! |
This was referenced Aug 27, 2021
stuartmorgan
pushed a commit
that referenced
this pull request
Aug 28, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
…utter#4289) Relands flutter#4262 as the white list has been updated to allow the newer wait-on-check version.
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
…utter#4289) Relands flutter#4262 as the white list has been updated to allow the newer wait-on-check version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has added a
verbose
property for wait-on-check which greatly reduce the output.Each wait interval still produces an output so we still keep the 3 min interval for now so the output won't be too overwhelming.
This is tested in my personal repo here: https://github.com/cyanglaz/melos_test/runs/3414623441?check_suite_focus=true
Fixes flutter/flutter#85127
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.