Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Add Camera used to control video and take pictures #4168

Merged
merged 7 commits into from
Jul 20, 2021
Merged

[camera_web] Add Camera used to control video and take pictures #4168

merged 7 commits into from
Jul 20, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Jul 20, 2021

Adds Camera to camera_web plugin. It is used to play/stop the video stream and take a picture. May be constrained with CameraOptions.

Part of flutter/flutter#45297

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe
Copy link
Contributor Author

bselwe commented Jul 20, 2021

@ditman ditman changed the title [camera] Add Camera used to play/stop the video stream and take a picture [camera_web] Add Camera used to play/stop the video stream and take a picture Jul 20, 2021
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm guessing by the direction that this is going, that soon you'll implement a class that extends the CameraPlatform and uses this Camera object?

@ditman ditman merged commit 337dc68 into flutter:master Jul 20, 2021
@bselwe
Copy link
Contributor Author

bselwe commented Jul 21, 2021

Exactly, the next step is implementing availableCameras and createCamera that creates this Camera object.

@bselwe bselwe changed the title [camera_web] Add Camera used to play/stop the video stream and take a picture [camera_web] Add Camera used to control video and take pictures Jul 21, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants