Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(camera_web): add camera with options to play, stop and take a picture #3

Closed
wants to merge 9 commits into from
Closed

feat(camera_web): add camera with options to play, stop and take a picture #3

wants to merge 9 commits into from

Conversation

bselwe
Copy link

@bselwe bselwe commented Jul 8, 2021

Description

  • Added a web camera with options to play, stop and take a picture.
  • Update camera exceptions to throw CameraException with appropriate error codes rather than introducing new exception types as here. This is to stay consistent with the current camera plugin.
  • Updated takePicture to return an XFile rather than photobooth's CameraImage.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bselwe bselwe added the enhancement New feature or request label Jul 8, 2021
@bselwe bselwe assigned felangel and unassigned felangel Jul 8, 2021
@bselwe bselwe requested a review from felangel July 8, 2021 16:18
@bselwe bselwe self-assigned this Jul 8, 2021
ditman
ditman reviewed Jul 13, 2021
View reviewed changes
packages/camera/camera_web/lib/src/camera.dart
..append(videoElement);

// ignore: avoid_dynamic_calls
ui.platformViewRegistry.registerViewFactory(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you have all these... Wouldn't it be super easy to add an initial version of buildPreview?

Copy link
Author

@bselwe bselwe Jul 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! Could be one of the next PRs.

@bselwe bselwe mentioned this pull request Jul 14, 2021
Open
@bselwe
Copy link
Author

bselwe commented Jul 20, 2021

Closing, moved to flutter/plugins#4168.

@bselwe bselwe closed this Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman ditman left review comments

@felangel felangel Awaiting requested review from felangel

Assignees

@bselwe bselwe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bselwe @ditman @felangel