Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/go_router_builder/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.0.1

- Fixes unnecessary whitespace in generated `RelativeGoRouteData`.

## 4.0.0

- Make Route mixins public.
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router_builder/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies:
dev_dependencies:
# ...along with your other dev-dependencies
build_runner: ^2.6.0
go_router_builder: ^3.3.0
go_router_builder: ^4.0.1
```

### Source code
Expand Down
4 changes: 0 additions & 4 deletions packages/go_router_builder/example/lib/go_relative.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions packages/go_router_builder/lib/src/route_config.dart
Original file line number Diff line number Diff line change
Expand Up @@ -572,11 +572,10 @@ mixin $_mixinName on $routeDataClassName {
}

@override
String get routeConstructorParameters => '''
path: ${escapeDartString(path)},
${caseSensitive ? '' : 'caseSensitive: $caseSensitive,'}
${parentNavigatorKey == null ? '' : 'parentNavigatorKey: $parentNavigatorKey,'}
''';
String get routeConstructorParameters =>
'path: ${escapeDartString(path)},'
'${caseSensitive ? '' : 'caseSensitive: $caseSensitive,'}'
'${parentNavigatorKey == null ? '' : 'parentNavigatorKey: $parentNavigatorKey,'}';

@override
String get routeDataClassName => 'RelativeGoRouteData';
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router_builder/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: go_router_builder
description: >-
A builder that supports generated strongly-typed route helpers for
package:go_router
version: 4.0.0
version: 4.0.1
repository: https://github.com/flutter/packages/tree/main/packages/go_router_builder
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router_builder%22

Expand Down
8 changes: 2 additions & 6 deletions packages/go_router_builder/tool/run_tests.dart
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,8 @@ Future<void> main() async {
}

// Apply consistent formatting to both generated and expected code for comparison.
final String generated = formatter.format(
results.join().replaceAll('\n', ''),
);
final String expected = formatter.format(
expectResult.replaceAll('\n', ''),
);
final String generated = formatter.format(results.join('\n\n').trim());
final String expected = formatter.format(expectResult.trim());
expect(generated, equals(expected));
}, timeout: const Timeout(Duration(seconds: 100)));
}
Expand Down