[go_router_builder] Fix unnecessary whitespace in generated RelativeGoRouteData
#9875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMirbt
force-pushed
the
go-router-builder/relative-route-generation-newlines
branch
from
9216893 to
5609fec
Compare
LukasMirbt
changed the title
RelativeGoRouteDataRelativeGoRouteData
LukasMirbt
force-pushed
the
go-router-builder/relative-route-generation-newlines
branch
5 times, most recently
from
c28d77e to
dc25089
Compare
LukasMirbt
force-pushed
the
go-router-builder/relative-route-generation-newlines
branch
from
9fea188 to
82edbad
Compare
Contributor
Author
|
@chunhtai Ready to autosubmit? |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2025
…RelativeGoRouteData` (flutter/packages#9875)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 4, 2025
flutter/packages@42bb347...98580c6 2025-09-04 [email protected] [mustache_template] Initial import (flutter/packages#9944) 2025-09-04 [email protected] [google_maps_flutter_web] Omit styles when cloudMapId is set (flutter/packages#9869) 2025-09-03 [email protected] [go_router_builder] Fix unnecessary whitespace in generated `RelativeGoRouteData` (flutter/packages#9875) 2025-09-03 [email protected] [google_maps_flutter_web] Stop listening to map events when disposed (flutter/packages#9250) 2025-09-03 [email protected] [flutter_svg] loader buffer fix (flutter/packages#9898) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@42bb347...98580c6 2025-09-04 [email protected] [mustache_template] Initial import (flutter/packages#9944) 2025-09-04 [email protected] [google_maps_flutter_web] Omit styles when cloudMapId is set (flutter/packages#9869) 2025-09-03 [email protected] [go_router_builder] Fix unnecessary whitespace in generated `RelativeGoRouteData` (flutter/packages#9875) 2025-09-03 [email protected] [google_maps_flutter_web] Stop listening to map events when disposed (flutter/packages#9250) 2025-09-03 [email protected] [flutter_svg] loader buffer fix (flutter/packages#9898) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
flutter/packages@42bb347...98580c6 2025-09-04 [email protected] [mustache_template] Initial import (flutter/packages#9944) 2025-09-04 [email protected] [google_maps_flutter_web] Omit styles when cloudMapId is set (flutter/packages#9869) 2025-09-03 [email protected] [go_router_builder] Fix unnecessary whitespace in generated `RelativeGoRouteData` (flutter/packages#9875) 2025-09-03 [email protected] [google_maps_flutter_web] Stop listening to map events when disposed (flutter/packages#9250) 2025-09-03 [email protected] [flutter_svg] loader buffer fix (flutter/packages#9898) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@42bb347...98580c6 2025-09-04 [email protected] [mustache_template] Initial import (flutter/packages#9944) 2025-09-04 [email protected] [google_maps_flutter_web] Omit styles when cloudMapId is set (flutter/packages#9869) 2025-09-03 [email protected] [go_router_builder] Fix unnecessary whitespace in generated `RelativeGoRouteData` (flutter/packages#9875) 2025-09-03 [email protected] [google_maps_flutter_web] Stop listening to map events when disposed (flutter/packages#9250) 2025-09-03 [email protected] [flutter_svg] loader buffer fix (flutter/packages#9898) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen in the go_router_builder relative route example, there is unnecessary whitespace in the generated output of
RelativeGoRouteData.This PR fixes the whitespace issue and adjusts
run_tests.dartto catch similar issues/regressions in the future.Closes flutter/flutter#174339.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3