-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[pigeon] Adds overrides for constructors and static members of ProxyApis #9515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 42 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
b125dfa
start of overrides generation
bparrishMines 733fabc
move constructor creation to method
bparrishMines 3b957d1
create method create function types
bparrishMines 2a98678
create method for getting constructor params
bparrishMines fbe6bd2
add support for static fields
bparrishMines 370f2ce
overrides for static methods
bparrishMines 893abd8
generating the constructor override
bparrishMines b5f1c82
fix constructor overrides
bparrishMines 350aaa3
fix wrong api names
bparrishMines eaf9f15
use null checker
bparrishMines 89fab8c
override static attached fields
bparrishMines 35cc467
override static methods
bparrishMines 69363f9
add reset method
bparrishMines 04be6d8
formatter
bparrishMines 6393d86
visible for testing
bparrishMines 1a6ad6c
documentation of overrides classes
bparrishMines 334e1b7
improve docs
bparrishMines c1cad06
Merge branch 'main' of github.com:flutter/packages into pigeon_overrides
bparrishMines da55dfe
fix proxy api tests
bparrishMines 3f98efe
fix generator tests and add overrides test
bparrishMines eced2c6
add overrides tests
bparrishMines e01b9f9
remove messenger and manager from overrides
bparrishMines fa6f30e
change to pigeon_ as value
bparrishMines e81fe9d
Merge branch 'main' of github.com:flutter/packages into pigeon_overrides
bparrishMines 9fa4634
version bump
bparrishMines 69e1576
fix changelog
bparrishMines 75afb7e
dont add comma
bparrishMines 1b35033
Merge branch 'main' of github.com:flutter/packages into pigeon_overrides
bparrishMines ae97278
use default constructor name
bparrishMines 1fd2c0f
change to a singular class
bparrishMines 2d66e33
move reset method
bparrishMines fb10295
fix tests
bparrishMines 50cbf09
use new keyword
bparrishMines 0808c11
fix tests
bparrishMines 84da64e
Fix unit tests
bparrishMines 4611198
Merge branch 'main' of github.com:flutter/packages into pigeon_overrides
bparrishMines d9222c2
change to define type
bparrishMines e427c9b
docs and formatting
bparrishMines 6581526
Merge branch 'main' of github.com:flutter/packages into pigeon_overrides
bparrishMines bda0ab6
improve docs
bparrishMines e9df002
update detached constructor
bparrishMines 83068ed
update copy method
bparrishMines 009da2d
fix test name
bparrishMines 78658c2
unneeded comments
bparrishMines 06402b9
move method to helper file
bparrishMines 6931701
forgot to add helper file
bparrishMines bc7e32f
move last missing method
bparrishMines a6428b9
change directive name
bparrishMines c2326bc
some code improvements
bparrishMines cd418e7
improve docs and move methods
bparrishMines 8080891
remove empty check
bparrishMines f17b54d
Merge branch 'main' of github.com:flutter/packages into pigeon_overrides
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use a little clarity on what
ProxyApiis referencing in each use of the name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this one and I will also improve documentation for the other methods in the followup PR as well. I will try to improve the distinction of what a
ProxyApiis.