Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jun 27, 2025

Adds PigeonOverrides class that contains overrides for all constructors and static members of ProxyApis.

I changed it to have only a single PigeonOverrides instead of having a separate overrides class for each proxy api. This makes it easier to export the generated proxy api classes without needing to hide/show specific classes.

I manually verified this only breaks one line in camera_android_camerax and one line in webview_flutter_android.

Also TIL:

class MyClass {
  MyClass();          <--
                           These are considered the same.
  MyClass.new();      <--
}

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025
@auto-submit auto-submit bot merged commit f0a66f1 into flutter:main Jul 17, 2025
78 checks passed
@bparrishMines bparrishMines deleted the pigeon_overrides branch July 17, 2025 22:13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jul 21, 2025
flutter/packages@cb8fef6...9c85e5e

2025-07-21 [email protected] Roll Flutter from
70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658)
2025-07-21 [email protected] [google_sign_in] Update to
GoogleSignIn-iOS 9 (flutter/packages#9655)
2025-07-20 [email protected] Roll Flutter from
440713c to 70a3c3c (11 revisions) (flutter/packages#9653)
2025-07-20 [email protected] Have Gemini ignore Flutter version
pin (flutter/packages#9647)
2025-07-18 [email protected] Roll Flutter from
9c626d9 to 440713c (19 revisions) (flutter/packages#9646)
2025-07-18 [email protected] [camera_avfoundation]
Implementation swift migration - part 8 (flutter/packages#9635)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/webview_flutter/webview_flutter_android/android
(flutter/packages#9609)
2025-07-17 [email protected] [two_dimensional_scrollables] Fix
missing leading cache extent for TableView (flutter/packages#9636)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/interactive_media_ads/android (flutter/packages#9623)
2025-07-17 [email protected] [pigeon] Adds
overrides for constructors and static members of ProxyApis
(flutter/packages#9515)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jul 21, 2025
flutter/packages@cb8fef6...9c85e5e

2025-07-21 [email protected] Roll Flutter from
70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658)
2025-07-21 [email protected] [google_sign_in] Update to
GoogleSignIn-iOS 9 (flutter/packages#9655)
2025-07-20 [email protected] Roll Flutter from
440713c to 70a3c3c (11 revisions) (flutter/packages#9653)
2025-07-20 [email protected] Have Gemini ignore Flutter version
pin (flutter/packages#9647)
2025-07-18 [email protected] Roll Flutter from
9c626d9 to 440713c (19 revisions) (flutter/packages#9646)
2025-07-18 [email protected] [camera_avfoundation]
Implementation swift migration - part 8 (flutter/packages#9635)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/webview_flutter/webview_flutter_android/android
(flutter/packages#9609)
2025-07-17 [email protected] [two_dimensional_scrollables] Fix
missing leading cache extent for TableView (flutter/packages#9636)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/interactive_media_ads/android (flutter/packages#9623)
2025-07-17 [email protected] [pigeon] Adds
overrides for constructors and static members of ProxyApis
(flutter/packages#9515)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
flutter/packages@cb8fef6...9c85e5e

2025-07-21 [email protected] Roll Flutter from
70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658)
2025-07-21 [email protected] [google_sign_in] Update to
GoogleSignIn-iOS 9 (flutter/packages#9655)
2025-07-20 [email protected] Roll Flutter from
440713c to 70a3c3c (11 revisions) (flutter/packages#9653)
2025-07-20 [email protected] Have Gemini ignore Flutter version
pin (flutter/packages#9647)
2025-07-18 [email protected] Roll Flutter from
9c626d9 to 440713c (19 revisions) (flutter/packages#9646)
2025-07-18 [email protected] [camera_avfoundation]
Implementation swift migration - part 8 (flutter/packages#9635)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/webview_flutter/webview_flutter_android/android
(flutter/packages#9609)
2025-07-17 [email protected] [two_dimensional_scrollables] Fix
missing leading cache extent for TableView (flutter/packages#9636)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/interactive_media_ads/android (flutter/packages#9623)
2025-07-17 [email protected] [pigeon] Adds
overrides for constructors and static members of ProxyApis
(flutter/packages#9515)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…pis (flutter#9515)

Adds `PigeonOverrides` class that contains overrides for all constructors and static members of ProxyApis.

I changed it to have only a single `PigeonOverrides` instead of having a separate overrides class for each proxy api. This makes it easier to export the generated proxy api classes without needing to `hide/show` specific classes.

I manually verified this only breaks one line in `camera_android_camerax` and one line in `webview_flutter_android`.

Also TIL:

```
class MyClass {
  MyClass();          <--
                           These are considered the same.
  MyClass.new();      <--
}
```

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
auto-submit bot pushed a commit that referenced this pull request Aug 11, 2025
…ons to a separate file (#9756)

Follow up to #9515 that moves Dart ProxyApi methods to a separate file.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
flutter/packages@cb8fef6...9c85e5e

2025-07-21 [email protected] Roll Flutter from
70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658)
2025-07-21 [email protected] [google_sign_in] Update to
GoogleSignIn-iOS 9 (flutter/packages#9655)
2025-07-20 [email protected] Roll Flutter from
440713c to 70a3c3c (11 revisions) (flutter/packages#9653)
2025-07-20 [email protected] Have Gemini ignore Flutter version
pin (flutter/packages#9647)
2025-07-18 [email protected] Roll Flutter from
9c626d9 to 440713c (19 revisions) (flutter/packages#9646)
2025-07-18 [email protected] [camera_avfoundation]
Implementation swift migration - part 8 (flutter/packages#9635)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/webview_flutter/webview_flutter_android/android
(flutter/packages#9609)
2025-07-17 [email protected] [two_dimensional_scrollables] Fix
missing leading cache extent for TableView (flutter/packages#9636)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/interactive_media_ads/android (flutter/packages#9623)
2025-07-17 [email protected] [pigeon] Adds
overrides for constructors and static members of ProxyApis
(flutter/packages#9515)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
flutter/packages@cb8fef6...9c85e5e

2025-07-21 [email protected] Roll Flutter from
70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658)
2025-07-21 [email protected] [google_sign_in] Update to
GoogleSignIn-iOS 9 (flutter/packages#9655)
2025-07-20 [email protected] Roll Flutter from
440713c to 70a3c3c (11 revisions) (flutter/packages#9653)
2025-07-20 [email protected] Have Gemini ignore Flutter version
pin (flutter/packages#9647)
2025-07-18 [email protected] Roll Flutter from
9c626d9 to 440713c (19 revisions) (flutter/packages#9646)
2025-07-18 [email protected] [camera_avfoundation]
Implementation swift migration - part 8 (flutter/packages#9635)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/webview_flutter/webview_flutter_android/android
(flutter/packages#9609)
2025-07-17 [email protected] [two_dimensional_scrollables] Fix
missing leading cache extent for TableView (flutter/packages#9636)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/interactive_media_ads/android (flutter/packages#9623)
2025-07-17 [email protected] [pigeon] Adds
overrides for constructors and static members of ProxyApis
(flutter/packages#9515)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
flutter/packages@cb8fef6...9c85e5e

2025-07-21 [email protected] Roll Flutter from
70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658)
2025-07-21 [email protected] [google_sign_in] Update to
GoogleSignIn-iOS 9 (flutter/packages#9655)
2025-07-20 [email protected] Roll Flutter from
440713c to 70a3c3c (11 revisions) (flutter/packages#9653)
2025-07-20 [email protected] Have Gemini ignore Flutter version
pin (flutter/packages#9647)
2025-07-18 [email protected] Roll Flutter from
9c626d9 to 440713c (19 revisions) (flutter/packages#9646)
2025-07-18 [email protected] [camera_avfoundation]
Implementation swift migration - part 8 (flutter/packages#9635)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/webview_flutter/webview_flutter_android/android
(flutter/packages#9609)
2025-07-17 [email protected] [two_dimensional_scrollables] Fix
missing leading cache extent for TableView (flutter/packages#9636)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/interactive_media_ads/android (flutter/packages#9623)
2025-07-17 [email protected] [pigeon] Adds
overrides for constructors and static members of ProxyApis
(flutter/packages#9515)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Nov 17, 2025
Pigeon versions <26.0.4 aren't compatible with `analyzer` 8.x, which is causing conflicts for flutter/flutter, so this updates the entire repo to 26.

Related: flutter/flutter#178270

Manual fixes:
- Updates `camera_android_camerax` and `webview_flutter_android` for #9515
- Adds the `pigeonVar_*` overrides to the `url_launcher_windows` tests
- Removes equality extensions to Pigeon data classes in `in_app_purchase_storekit`, as they are now generated by Pigeon, causing redeclaration errors.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
flutter/packages@cb8fef6...9c85e5e

2025-07-21 [email protected] Roll Flutter from
70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658)
2025-07-21 [email protected] [google_sign_in] Update to
GoogleSignIn-iOS 9 (flutter/packages#9655)
2025-07-20 [email protected] Roll Flutter from
440713c to 70a3c3c (11 revisions) (flutter/packages#9653)
2025-07-20 [email protected] Have Gemini ignore Flutter version
pin (flutter/packages#9647)
2025-07-18 [email protected] Roll Flutter from
9c626d9 to 440713c (19 revisions) (flutter/packages#9646)
2025-07-18 [email protected] [camera_avfoundation]
Implementation swift migration - part 8 (flutter/packages#9635)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/webview_flutter/webview_flutter_android/android
(flutter/packages#9609)
2025-07-17 [email protected] [two_dimensional_scrollables] Fix
missing leading cache extent for TableView (flutter/packages#9636)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1
in /packages/interactive_media_ads/android (flutter/packages#9623)
2025-07-17 [email protected] [pigeon] Adds
overrides for constructors and static members of ProxyApis
(flutter/packages#9515)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants