-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 45 commits into
flutter:main
from
kaiquegazola:feature/in-app-purchase-storekit2-win-back-offers
Jun 2, 2025
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
b372744
feat: add win back offer
kaiquegazola bedc5f8
feat: add app account token parameter
kaiquegazola 63d2270
feat: add promotional offer param
kaiquegazola 1fa0441
test: add win back offer, promotional and app account token tests
kaiquegazola 1b298c6
chore: add promotional offers in example app
kaiquegazola 7faddc0
test: add Sk2PurchaseParam tests
kaiquegazola b67d029
chore: bump version
kaiquegazola caf6cc9
Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…
kaiquegazola ea32bd1
fix: format files
kaiquegazola 45f6fb2
Merge remote-tracking branch 'origin/feature/in-app-purchase-storekit…
kaiquegazola 3822279
Merge remote-tracking branch 'origin/main' into feature/in-app-purcha…
kaiquegazola acaa4fb
feat: add checkWinBackOfferEligibility
kaiquegazola 39f94da
fix: add compiler check to avoid older xcode issues
kaiquegazola c696b03
fix: fix SK2SubscriptionOfferSignatureMessage usage
kaiquegazola 8c9bd1e
chore: bump version
kaiquegazola 01cf3c0
fix: fix unsupported compiler test
kaiquegazola 36314b8
Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…
kaiquegazola 73257b2
fix: fix promotional offer list test in unsupported compilers
kaiquegazola 5362391
refactor: remove comment
kaiquegazola a64d3bc
Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…
kaiquegazola e327191
refactor: remove #if compiler(>=6.0) directive in IAP SK2
kaiquegazola ef114df
Merge remote-tracking branch 'origin/feature/in-app-purchase-storekit…
kaiquegazola 26784e4
Merge remote-tracking branch 'origin/main' into feature/in-app-purcha…
kaiquegazola 179a4df
chore: regenerate pigeon files
kaiquegazola a10dbb9
fix: fix IAP SK example win back offer
kaiquegazola d8c090a
chore: dump version
kaiquegazola 5d213ab
refactor: remove unused unverified case
kaiquegazola 853cc99
Merge remote-tracking branch 'origin/main' into feature/in-app-purcha…
kaiquegazola 26596f2
fix: fix merge conflicts
kaiquegazola 6377464
fix: dart doc period sentence
kaiquegazola 8d68c8c
refactor: change checkWinBackOfferEligibility to isWinBackOfferEligible
kaiquegazola f47b7d2
chore: update CHANGELOG to reflect new isWinBackOfferEligible function
kaiquegazola 6abc429
refactor: change checkWinBackOfferEligibility to isWinBackOfferEligib…
kaiquegazola cd59de0
refactor: simplify eligibility check with contains and verified check
kaiquegazola baec1a4
refactor: move SK2SubscriptionOfferSignature to sk2_promotional_offer…
kaiquegazola 87a424c
refactor: mark SK2PromotionalOffer as final
kaiquegazola 09b651a
refactor: add Sk2PurchaseParam.fromOffer factory for cleaner offer ha…
kaiquegazola 0792274
docs: improve isWinBackOfferEligible error handling documentation
kaiquegazola 7f9d9c2
refactor: make _convertPromotionalOffer static
kaiquegazola 8e96dbd
docs: improve buyNonConsumable documentation with clearer usage examples
kaiquegazola 2b4099e
Merge remote-tracking branch 'origin/main' into feature/in-app-purcha…
kaiquegazola a6697e1
docs: fix missing periods
kaiquegazola 0f7530d
refactor: make options final exhaustive
kaiquegazola af4dfff
Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…
kaiquegazola 69025cb
Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…
LouiseHsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 6 additions & 1 deletion
7
packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if the developer passes in a nonce that is not a valid UUID it would crash the app? That seems to be a bit heavy-handed. Is there an error reporting mechanism for programmer errors like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, it felt a bit heavy-handed, but I followed the existing pattern in this file. Happy to change it if there’s a preferred way — any suggestion on the standard we should follow here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I didn't know it was an existing pattern. In that case if there's a better way to handle these errors more gracefully we can refactor those later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you show me the way, I can do a PR later.