[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474

kaiquegazola · 2025-01-22T02:34:50Z

Adds StoreKit2 support for:

Win Back Offers (requires Xcode 16 or later)
- New isWinBackOfferEligible method for eligibility checks
Promotional Offers
Fixes introductory pricing handling in promotional offers list
Fixes appAccountToken handling for StoreKit2 purchases

Fixes:
flutter/flutter#161393
flutter/flutter#160826

Pre-launch Checklist

…ffers

…2-win-back-offers' into feature/in-app-purchase-storekit2-win-back-offers

LouiseHsu · 2025-01-28T21:27:20Z

Hey just letting you know Ive looked at your PR, and it looks really good! I've checked out your branch and it seems to work well locally. However our tests are failing to compile because currently they're running on ios 17.0. I'm taking a look to see if theres a way around this, but if you want to try building your branch on Xcode 15 or lower that would be really helpful too!

kaiquegazola · 2025-01-29T14:05:30Z

Thanks for for testing it locally

It seems we’re currently blocked by flutter/flutter#148870. Also, I think we should add a CHANGELOG warning regarding this Xcode requirement.

Maybe an #if compiler directive could help here, but I haven’t tested it yet, so I’m not sure if it actually works. Let me know what you think

…se-storekit2-win-back-offers # Conflicts: # packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md

…ffers

kaiquegazola · 2025-02-17T19:57:23Z

Hi @LouiseHsu, when you have a moment, could you please take a look at this PR? Thanks

…ffers

…le in tests

….dart

…ndling

…se-storekit2-win-back-offers # Conflicts: # packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md

LongCatIsLooong

Thanks for the explanation! LGTM (with nits and a few more questions).

...ages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart

LongCatIsLooong · 2025-05-27T21:07:21Z

..._app_purchase_storekit/Sources/in_app_purchase_storekit/StoreKit2/StoreKit2Translators.swift

+
+  var nonceAsUUID: UUID {
+    guard let uuid = UUID(uuidString: nonce) else {
+      fatalError("Invalid UUID format for nonce: \(nonce)")


Ah I didn't know it was an existing pattern. In that case if there's a better way to handle these errors more gracefully we can refactor those later.

..._app_purchase_storekit/Sources/in_app_purchase_storekit/StoreKit2/StoreKit2Translators.swift

LongCatIsLooong · 2025-05-28T17:42:21Z

...ages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart

  Future<bool> buyNonConsumable({required PurchaseParam purchaseParam}) async {
    if (_useStoreKit2) {
-      final SK2ProductPurchaseOptions options = SK2ProductPurchaseOptions(
+      late SK2ProductPurchaseOptions options;


(This doesnt seem to have been addressed).

LongCatIsLooong · 2025-05-28T17:54:28Z

...ages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart

-      final SK2ProductPurchaseOptions options = SK2ProductPurchaseOptions(
+      late SK2ProductPurchaseOptions options;
+
+      if (purchaseParam is Sk2PurchaseParam) {


Thanks for the detailed explanation! That sounds good to me. From reading the docs it seems that store_kit_2_wrappers and store_kit_wrappers are supposed to reflect the store kit 2 and store kit 1 API and the platform agnostic abstraction happens in in-app-purchase and in-app-purchase-storekit, I believe that's inline with what you said.

So with this patch developers would be able to use win back offers, but only with in_app_purchase_storekit / store_kit_2_wrappers?

…ffers

auto-submit · 2025-06-02T21:45:05Z

autosubmit label was removed for flutter/packages/8474, because This PR has not met approval requirements for merging. Changes were requested by {stuartmorgan-g}, please make the needed changes and resubmit this PR.
The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

LouiseHsu · 2025-06-02T21:46:11Z

@stuartmorgan-g do you have any outstanding concerns about this PR?

stuartmorgan-g · 2025-06-02T23:46:13Z

Sorry, I didn't realize I still had a blocking request on this.

Obsolete

… promotional offers (flutter/packages#8474)

flutter/packages@4463066...1765c95 2025-06-03 [email protected] [video_player] Platform view support (flutter/packages#8810) 2025-06-02 [email protected] [in_app_purchase_storekit] Add support to win back offers / promotional offers (flutter/packages#8474) 2025-06-02 [email protected] [two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table example (flutter/packages#8189) 2025-05-30 [email protected] [all_packages] Bump `compileSdk` version to 35 (flutter/packages#9168) 2025-05-30 [email protected] Roll Flutter (stable) from be698c4 to b25305a (11 revisions) (flutter/packages#9342) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…al offers (flutter#8474) **Adds StoreKit2 support for**: - **Win Back Offers** (requires Xcode 16 or later) - New `isWinBackOfferEligible` method for eligibility checks - **Promotional Offers** - Fixes introductory pricing handling in promotional offers list - Fixes `appAccountToken` handling for StoreKit2 purchases Fixes: flutter/flutter#161393 flutter/flutter#160826

kaiquegazola added 7 commits January 21, 2025 14:19

feat: add win back offer

b372744

feat: add app account token parameter

bedc5f8

feat: add promotional offer param

63d2270

test: add win back offer, promotional and app account token tests

1fa0441

chore: add promotional offers in example app

1b298c6

test: add Sk2PurchaseParam tests

7faddc0

chore: bump version

b67d029

kaiquegazola requested a review from LouiseHsu as a code owner January 22, 2025 02:34

github-actions bot added p: in_app_purchase platform-ios platform-macos labels Jan 22, 2025

kaiquegazola and others added 3 commits January 21, 2025 23:35

Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…

caf6cc9

…ffers

fix: format files

ea32bd1

Merge remote-tracking branch 'origin/feature/in-app-purchase-storekit…

45f6fb2

…2-win-back-offers' into feature/in-app-purchase-storekit2-win-back-offers

Merge remote-tracking branch 'origin/main' into feature/in-app-purcha…

3822279

…se-storekit2-win-back-offers # Conflicts: # packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md

kaiquegazola marked this pull request as draft January 30, 2025 19:37

kaiquegazola and others added 8 commits January 30, 2025 21:58

feat: add checkWinBackOfferEligibility

acaa4fb

fix: add compiler check to avoid older xcode issues

39f94da

fix: fix SK2SubscriptionOfferSignatureMessage usage

c696b03

chore: bump version

8c9bd1e

fix: fix unsupported compiler test

01cf3c0

Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…

36314b8

…ffers

fix: fix promotional offer list test in unsupported compilers

73257b2

refactor: remove comment

5362391

kaiquegazola marked this pull request as ready for review January 31, 2025 03:14

Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…

a64d3bc

…ffers

stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Mar 6, 2025

kaiquegazola added 11 commits May 23, 2025 21:09

chore: update CHANGELOG to reflect new isWinBackOfferEligible function

f47b7d2

refactor: change checkWinBackOfferEligibility to isWinBackOfferEligib…

6abc429

…le in tests

refactor: simplify eligibility check with contains and verified check

cd59de0

refactor: move SK2SubscriptionOfferSignature to sk2_promotional_offer…

baec1a4

….dart

refactor: mark SK2PromotionalOffer as final

87a424c

refactor: add Sk2PurchaseParam.fromOffer factory for cleaner offer ha…

09b651a

…ndling

docs: improve isWinBackOfferEligible error handling documentation

0792274

refactor: make _convertPromotionalOffer static

7f9d9c2

docs: improve buyNonConsumable documentation with clearer usage examples

8e96dbd

Merge remote-tracking branch 'origin/main' into feature/in-app-purcha…

2b4099e

…se-storekit2-win-back-offers # Conflicts: # packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md

docs: fix missing periods

a6697e1

kaiquegazola requested a review from LongCatIsLooong May 24, 2025 02:21

LongCatIsLooong approved these changes May 28, 2025

View reviewed changes

kaiquegazola and others added 3 commits May 31, 2025 12:31

refactor: make options final exhaustive

0f7530d

Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…

af4dfff

…ffers

Merge branch 'main' into feature/in-app-purchase-storekit2-win-back-o…

69025cb

…ffers

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025

auto-submit bot merged commit a06b67b into flutter:main Jun 2, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 3, 2025

a06b67bdb [in_app_purchase_storekit] Add support to win back offers /…

e80bee7

… promotional offers (flutter/packages#8474)

engine-flutter-autoroll mentioned this pull request Jun 3, 2025

Roll Packages from 44630668aec6 to 1765c952032c (5 revisions) flutter/flutter#169933

Merged

kaiquegazola deleted the feature/in-app-purchase-storekit2-win-back-offers branch June 3, 2025 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474

[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474

Uh oh!

kaiquegazola commented Jan 22, 2025 •

edited

Loading

Uh oh!

LouiseHsu commented Jan 28, 2025

Uh oh!

kaiquegazola commented Jan 29, 2025

Uh oh!

kaiquegazola commented Feb 17, 2025

Uh oh!

LongCatIsLooong left a comment •

edited

Loading

Uh oh!

Uh oh!

LongCatIsLooong May 27, 2025

Uh oh!

Uh oh!

LongCatIsLooong May 28, 2025

Uh oh!

LongCatIsLooong May 28, 2025

Uh oh!

auto-submit bot commented Jun 2, 2025

Uh oh!

LouiseHsu commented Jun 2, 2025

Uh oh!

stuartmorgan-g commented Jun 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474

[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474

Uh oh!

Conversation

kaiquegazola commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

LouiseHsu commented Jan 28, 2025

Uh oh!

kaiquegazola commented Jan 29, 2025

Uh oh!

kaiquegazola commented Feb 17, 2025

Uh oh!

LongCatIsLooong left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LongCatIsLooong May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LongCatIsLooong May 28, 2025

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong May 28, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jun 2, 2025

Uh oh!

LouiseHsu commented Jun 2, 2025

Uh oh!

stuartmorgan-g commented Jun 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kaiquegazola commented Jan 22, 2025 •

edited

Loading

LongCatIsLooong left a comment •

edited

Loading