Dispose the ExoPlayer before SurfaceProducer.
#7824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
approved these changes
Oct 8, 2024
reidbaker
approved these changes
Oct 8, 2024
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/7824, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 9, 2024
flutter/packages@8fbf4cd...9d00fb1 2024-10-09 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `CompanionAd` (flutter/packages#7823) 2024-10-08 [email protected] Disable `SurfaceProducer.Callback` when the surface is disposed manually. (flutter/packages#7827) 2024-10-08 [email protected] Dispose the `ExoPlayer` before `SurfaceProducer`. (flutter/packages#7824) 2024-10-08 [email protected] [pigeon] Use non-nullable generics in example app (flutter/packages#7817) 2024-10-08 [email protected] Manually Roll Flutter (stable) from 4cf269e to 2663184 (5 revisions) (flutter/packages#7819) 2024-10-08 [email protected] [camera] Update iOS Pigeon for non-nullable generics (flutter/packages#7787) 2024-10-08 [email protected] [in_app_purchase] Update Android Pigeon for non-nullable generics (flutter/packages#7788) 2024-10-08 [email protected] [WIP] Updated applying gradle plugin for flutter_plugin_android_lifecycles (flutter/packages#7786) 2024-10-08 [email protected] Manual roll Flutter from ec2e12b to 0917e9d (29 revisions) (flutter/packages#7816) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1 of the 2 reported issues in flutter/flutter#156158 (dispose)
I'd like to write a better (integration) test for this (flutter/flutter#156424), but honestly this should have been caught by existing tests (which call dispose). I am asking on Discord for more clarification.