Skip to content

[image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods #6707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
May 13, 2024
Merged

[image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods #6707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a1c2c5
make all headers public for SwiftPM to keep inline with CocoaPods
vashworth May 9, 2024
80d2bd8
update change log
vashworth May 9, 2024
b23078b
fix import order
vashworth May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/image_picker/image_picker_ios/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.8.11+1

* Makes all headers public with Swift Package Manager integration to keep inline with CocoaPods.

## 0.8.11

* Adds Swift Package Manager compatibility.
Expand Down
2 changes: 1 addition & 1 deletion ...ker/image_picker_ios/ios/image_picker_ios/Sources/image_picker_ios/FLTImagePickerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
#import <PhotosUI/PhotosUI.h>
#import <UIKit/UIKit.h>

#import "./include/image_picker_ios/messages.g.h"
#import "FLTImagePickerImageUtil.h"
#import "FLTImagePickerMetaDataUtil.h"
#import "FLTImagePickerPhotoAssetUtil.h"
#import "FLTPHPickerSaveImageToPathOperation.h"
#import "messages.g.h"

@implementation FLTImagePickerMethodCallContext
- (instancetype)initWithResult:(nonnull FlutterResultAdapter)result {
Expand Down
0 ...mage_picker_ios/FLTImagePickerImageUtil.h → ...mage_picker_ios/FLTImagePickerImageUtil.h
View file
Open in desktop
File renamed without changes.
0 ...e_picker_ios/FLTImagePickerMetaDataUtil.h → ...e_picker_ios/FLTImagePickerMetaDataUtil.h
View file
Open in desktop
File renamed without changes.
0 ...picker_ios/FLTImagePickerPhotoAssetUtil.h → ...picker_ios/FLTImagePickerPhotoAssetUtil.h
View file
Open in desktop
File renamed without changes.
0 ...ge_picker_ios/FLTImagePickerPlugin_Test.h → ...ge_picker_ios/FLTImagePickerPlugin_Test.h
View file
Open in desktop
File renamed without changes.
0 ...ios/FLTPHPickerSaveImageToPathOperation.h → ...ios/FLTPHPickerSaveImageToPathOperation.h
View file
Open in desktop
File renamed without changes.
0 ...ios/Sources/image_picker_ios/messages.g.h → ...ios/include/image_picker_ios/messages.g.h
View file
Open in desktop
File renamed without changes.
10 changes: 5 additions & 5 deletions ...r/image_picker_ios/ios/image_picker_ios/Sources/image_picker_ios/include/module.modulemap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ module image_picker_ios {
module * { export * }

explicit module Test {
header "../FLTImagePickerPlugin_Test.h"
header "../FLTImagePickerImageUtil.h"
header "../FLTImagePickerMetaDataUtil.h"
header "../FLTImagePickerPhotoAssetUtil.h"
header "../FLTPHPickerSaveImageToPathOperation.h"
header "image_picker_ios/FLTImagePickerPlugin_Test.h"
header "image_picker_ios/FLTImagePickerImageUtil.h"
header "image_picker_ios/FLTImagePickerMetaDataUtil.h"
header "image_picker_ios/FLTImagePickerPhotoAssetUtil.h"
header "image_picker_ios/FLTPHPickerSaveImageToPathOperation.h"
}
}
2 changes: 1 addition & 1 deletion .../image_picker/image_picker_ios/ios/image_picker_ios/Sources/image_picker_ios/messages.g.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// Autogenerated from Pigeon (v17.0.0), do not edit directly.
// See also: https://pub.dev/packages/pigeon

#import "messages.g.h"
#import "./include/image_picker_ios/messages.g.h"

#if TARGET_OS_OSX
#import <FlutterMacOS/FlutterMacOS.h>
Expand Down
4 changes: 3 additions & 1 deletion packages/image_picker/image_picker_ios/pigeons/messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ import 'package:pigeon/pigeon.dart';
@ConfigurePigeon(PigeonOptions(
dartOut: 'lib/src/messages.g.dart',
dartTestOut: 'test/test_api.g.dart',
objcHeaderOut: 'ios/image_picker_ios/Sources/image_picker_ios/messages.g.h',
objcHeaderOut:
'ios/image_picker_ios/Sources/image_picker_ios/include/image_picker_ios/messages.g.h',
objcSourceOut: 'ios/image_picker_ios/Sources/image_picker_ios/messages.g.m',
objcOptions: ObjcOptions(
prefix: 'FLT',
headerIncludePath: './include/image_picker_ios/messages.g.h',
),
copyrightHeader: 'pigeons/copyright.txt',
))
Expand Down
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker_ios/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: image_picker_ios
description: iOS implementation of the image_picker plugin.
repository: https://github.com/flutter/packages/tree/main/packages/image_picker/image_picker_ios
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
version: 0.8.11
version: 0.8.11+1

environment:
sdk: ^3.3.0
Expand Down