Skip to content

[image_picker_android] Removes unneeded permissions from tests #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Mar 13, 2023
Merged

[image_picker_android] Removes unneeded permissions from tests #3433

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
405cf97
remove unneeded permissions from tests
tarrinneal Mar 10, 2023
2cfc2ce
update test names to reflect changes
tarrinneal Mar 10, 2023
c7dca4e
Merge branch 'main'
tarrinneal Mar 13, 2023
1ca4b99
merge fix
tarrinneal Mar 13, 2023
2eb4929
unfix the fix fix
tarrinneal Mar 13, 2023
5ddc988
another oopsy
tarrinneal Mar 13, 2023
a4abad6
found a couple more
tarrinneal Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions ...android/android/src/test/java/io/flutter/plugins/imagepicker/ImagePickerDelegateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre

@Test
@Config(sdk = 30)
public void
chooseImageFromGallery_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
.thenReturn(true);
public void chooseImageFromGallery_LaunchesChooseFromGalleryIntent() {
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, you regressed the capitalization fixes I made. Can you sweep this to make sure the letter after _ is always lower case?

Copy link
Contributor Author

@tarrinneal tarrinneal Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure, I had some weird merge conflict issues I should have handled more carefully.

Copy link
Contributor Author

@tarrinneal tarrinneal Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a couple you missed too I think


ImagePickerDelegate delegate = createDelegate();
delegate.chooseImageFromGallery(new ImageOutputOptions(null, null, null), false, mockResult);
Expand All @@ -163,10 +160,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre

@Test
@Config(minSdk = 33)
public void
chooseImageFromGallery_WithPhotoPicker_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
.thenReturn(true);
public void chooseImageFromGallery_WithPhotoPicker_LaunchesChooseFromGalleryIntent() {

ImagePickerDelegate delegate = createDelegate();
delegate.chooseImageFromGallery(new ImageOutputOptions(null, null, null), true, mockResult);
Expand All @@ -178,10 +172,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre

@Test
@Config(sdk = 30)
public void
chooseMultiImageFromGallery_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
.thenReturn(true);
public void chooseMultiImageFromGallery_LaunchesChooseFromGalleryIntent() {

ImagePickerDelegate delegate = createDelegate();
delegate.chooseMultiImageFromGallery(
Expand All @@ -195,10 +186,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre

@Test
@Config(minSdk = 33)
public void
chooseMultiImageFromGallery_WithPhotoPicker_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
.thenReturn(true);
public void chooseMultiImageFromGallery_WithPhotoPicker_LaunchesChooseFromGalleryIntent() {

ImagePickerDelegate delegate = createDelegate();
delegate.chooseMultiImageFromGallery(
Expand All @@ -212,10 +200,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre

@Test
@Config(sdk = 30)
public void
chooseVideoFromGallery_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
.thenReturn(true);
public void chooseVideoFromGallery_LaunchesChooseFromGalleryIntent() {

ImagePickerDelegate delegate = createDelegate();
delegate.chooseVideoFromGallery(new VideoOptions(null), true, mockResult);
Expand All @@ -227,10 +212,7 @@ public void chooseMultiImageFromGallery_whenPendingResultExists_finishesWithAlre

@Test
@Config(minSdk = 33)
public void
chooseVideoFromGallery_WithPhotoPicker_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() {
when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE))
.thenReturn(true);
public void chooseVideoFromGallery_WithPhotoPicker_LaunchesChooseFromGalleryIntent() {

ImagePickerDelegate delegate = createDelegate();
delegate.chooseVideoFromGallery(new VideoOptions(null), true, mockResult);
Expand Down