[image_picker_android] Removes unneeded permissions from tests #3433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-ios
platform-web
platform-windows
and removed
platform-ios
platform-web
platform-windows
labels
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks, i noticed this while I was working on MethodCall untangling yesterday and was thinking we should clean it up. Can you update the test names too so they don't say that's part of the test state?
...er_android/android/src/test/java/io/flutter/plugins/imagepicker/ImagePickerDelegateTest.java
Outdated
Show resolved
Hide resolved
| chooseImageFromGallery_whenHasExternalStoragePermission_launchesChooseFromGalleryIntent() { | ||
| when(mockPermissionManager.isPermissionGranted(Manifest.permission.READ_EXTERNAL_STORAGE)) | ||
| .thenReturn(true); | ||
| public void chooseImageFromGallery_LaunchesChooseFromGalleryIntent() { |
Collaborator
There was a problem hiding this comment.
Oh wait, you regressed the capitalization fixes I made. Can you sweep this to make sure the letter after _ is always lower case?
Contributor
Author
There was a problem hiding this comment.
for sure, I had some weird merge conflict issues I should have handled more carefully.
Contributor
Author
There was a problem hiding this comment.
found a couple you missed too I think
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…er#3433) [image_picker_android] Removes unneeded permissions from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were using a check for permissions that is not needed for image_picker to function. This pr removes them.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.