Skip to content

Include the examples cross imports checker in the analzyer. #190674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Aug 11, 2026
+26 −1
Merged

Include the examples cross imports checker in the analzyer. #190674

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e67c09
Include the examples cross imports checker in the analzyer.
justinmc Aug 6, 2026
c2d4c13
Remove multiple_windows example from knowns; it has already been migr…
justinmc Aug 6, 2026
ca6a335
Add missing known imports
justinmc Aug 6, 2026
fa256ed
Merge branch 'master' into cross-imports-examples-checker-activation
justinmc Aug 7, 2026
392e748
Fix order
justinmc Aug 7, 2026
5f88029
Merge branch 'master' into cross-imports-examples-checker-activation
justinmc Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dev/bots/analyze.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,14 @@ List<Validation> _getValidations({
path.join(flutterRoot, 'dev', 'bots', 'check_tests_cross_imports.dart'),
], workingDirectory: flutterRoot),
),
Validation(
'cross-imports-examples',
'Examples cross-import test validation...',
() => runCommand(dart, <String>[
'--enable-asserts',
path.join(flutterRoot, 'dev', 'bots', 'check_examples_cross_imports.dart'),
], workingDirectory: flutterRoot),
),
];
}

Expand Down
19 changes: 18 additions & 1 deletion dev/bots/check_examples_cross_imports.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,14 @@ class ExamplesCrossImportChecker {
'packages/flutter/examples/api/lib/widgets/scrollbar/raw_scrollbar.desktop.0.dart',
'packages/flutter/examples/api/lib/widgets/inherited_notifier/inherited_notifier.0.dart',
'packages/flutter/examples/api/lib/widgets/text_magnifier/text_magnifier.0.dart',
'packages/flutter/examples/api/lib/widgets/expansible/expansible.0.dart',
'packages/flutter/examples/api/lib/widgets/selection_container/selection_container.0.dart',
'packages/flutter/examples/api/lib/widgets/selection_container/selection_container_disabled.0.dart',
'packages/flutter/examples/api/lib/widgets/platform_menu_bar/platform_menu_bar.0.dart',
'packages/flutter/examples/api/lib/widgets/context_menu/editable_text_toolbar_builder.1.dart',
'packages/flutter/examples/api/lib/widgets/context_menu/context_menu_controller.0.dart',
'packages/flutter/examples/api/lib/widgets/context_menu/editable_text_toolbar_builder.0.dart',
'packages/flutter/examples/api/lib/widgets/selectable_region/selectable_region.0.dart',
'packages/flutter/examples/api/test/widgets/animated_grid/animated_grid.0_test.dart',
'packages/flutter/examples/api/test/widgets/animated_grid/sliver_animated_grid.0_test.dart',
'packages/flutter/examples/api/test/widgets/navigator_pop_handler/navigator_pop_handler.1_test.dart',
Expand Down Expand Up @@ -585,11 +593,20 @@ class ExamplesCrossImportChecker {
'packages/flutter/examples/api/test/widgets/scrollbar/raw_scrollbar.1_test.dart',
'packages/flutter/examples/api/test/widgets/inherited_notifier/inherited_notifier.0_test.dart',
'packages/flutter/examples/api/test/widgets/text_magnifier/text_magnifier.0_test.dart',
'packages/flutter/examples/api/test/widgets/selection_container/selection_container_disabled.0_test.dart',
'packages/flutter/examples/api/test/widgets/selection_container/selection_container.0_test.dart',
'packages/flutter/examples/api/test/widgets/platform_menu_bar/platform_menu_bar.0_test.dart',
'packages/flutter/examples/api/test/widgets/context_menu/context_menu_controller.0_test.dart',
'packages/flutter/examples/api/test/widgets/context_menu/editable_text_toolbar_builder.0_test.dart',
'packages/flutter/examples/api/test/widgets/context_menu/editable_text_toolbar_builder.1_test.dart',
'packages/flutter/examples/api/test/widgets/selectable_region/selectable_region.0_test.dart',
'examples/flutter_view/lib/main.dart',
'examples/texture/lib/main.dart',
};

static final RegExp _examplesPrefix = RegExp(r'packages[/\\]flutter[/\\]examples[/\\]api|examples');
static final RegExp _examplesPrefix = RegExp(
r'packages[/\\]flutter[/\\]examples[/\\]api|examples',
);

/// Find the `packages/flutter/examples/api/lib` and
/// `packages/flutter/examples/api/test` directories which contain the API
Expand Down